SV Egg Autonomous: Added the option with backup saves#1228
Open
Boombaastical wants to merge 3 commits into
Open
SV Egg Autonomous: Added the option with backup saves#1228Boombaastical wants to merge 3 commits into
Boombaastical wants to merge 3 commits into
Conversation
Collaborator
|
This is overly complicated for what you want to do. Just use audio to detect the shiny sound that's played during the hatch. Then take a video via the screenshot button after the egg is done hatching. |
Contributor
Author
|
The point is also to record the Trainer ID. For this, I don't want to add this extra step as part of the program, as this is specific for me, but the fact that you can rehatch eggs at no additional cost is an improvement over the other saving options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My purpose was to be able to take a video of the trainer profile with the shiny hatching from the egg in a single video. In our current option, my best bet was to:
-Save after picnic and all eggs have been fetched
-Save before every batch of 4-5 eggs
In both cases, it would use up ingredients, and it takes more time because the program needs to release all pokemon at the end.
So instead, I added an option to create a backup save after fetching all 30 eggs, but keeping the logic of "Save at the beginning and after keeping a baby". This way, it works exactly the same, but the backup save allows to go back to the moment where the shiny was part of the eggs, and thus I can manually take a video of it.
Backup saves in SV:
-Are created by:
--healing pokemon at a pokemon center (the option I chose for this PR)
--after finishing an online trade
-Are not created by:
--Any operation done by the current SV Egg Autonomous
--Flying somewhere, close or far
--Moving to another area
I have already tested the feature, and I could record the 3 videos in attachment.
Test.1.mp4
Test.2.mp4
Test.3.mp4